It is currently Thu Aug 16, 2018 8:05 pm



Forum locked This topic is locked, you cannot edit posts or make further replies.  [ 3 posts ] 
Author Message
 Post subject: Tuner.c Lockup issue
PostPosted: Sun May 19, 2013 8:39 pm 
Offline
User avatar

Joined: Sun May 19, 2013 8:32 pm
Posts: 12
Found a little issue running the latest master in the repo.

When I'm running TunerStudio, it seems to request data blocks in 255 byte chunks. When I run EMStudio, and have it request data blocks (via the 'r' command) in larger than 255 byte chunks, the ECU locks up (LED's 1,2,3,4 stop moving).

It seems to be when I request a chunk larger than exists inside the ECU that it does it? I've not done extensive testing to be sure... but this should certainly be looked at.

Maybe just some more checks and balances internally?


Top
 Profile  
 
 Post subject: Re: Tuner.c Lockup issue
PostPosted: Mon May 20, 2013 7:50 am 
Offline
User avatar

Joined: Sun May 19, 2013 8:32 pm
Posts: 12
So it seems in Tuner.c: http://code.google.com/p/open5xxxecu/so ... o=firmware

make_packet takes a size argument, and does not verify the size of memory before attempting a memcp, so this is likely just a segfault on the ECU side.

As Tuner Studio doesn't really give you any issues with it, and by the time you support other tuners you likely won't be using the same code, it's probably not worth fixing, just a quirk that is worth knowing about.


Top
 Profile  
 
 Post subject: Re: Tuner.c Lockup issue
PostPosted: Mon May 20, 2013 12:04 pm 
Offline
User avatar

Joined: Sat May 11, 2013 9:45 am
Posts: 729
Location: PA, USA
We are going to need a better/faster way to do com stuff but as you say, right now we need to just deal with what TS does :(


Top
 Profile  
 
Display posts from previous:  Sort by  
Forum locked This topic is locked, you cannot edit posts or make further replies.  [ 3 posts ] 

Who is online

Users browsing this forum: No registered users and 2 guests


You cannot post new topics in this forum
You cannot reply to topics in this forum
You cannot edit your posts in this forum
You cannot delete your posts in this forum
You cannot post attachments in this forum

Search for:
Jump to:  
cron
Theme designed by stylerbb.net © 2008
Powered by phpBB © 2000, 2002, 2005, 2007 phpBB Group
All times are UTC - 5 hours [ DST ]